fix(ci): resolve PG 17 showcase test failure#372
Merged
Conversation
Add missing dir to test:integration:showcase task so mise --env tls runs from tests/ where mise.tls.toml exists, correctly loading TLS environment variables (CS_DATABASE__HOST and CS_DATABASE__PORT). Fix quoting bug in proxy:up container detection where unquoted variable expansions collapsed multi-line docker ps output, causing grep and cut to select the wrong container when multiple postgres containers are running.
📝 WalkthroughWalkthroughMise.toml updated with improved shell quoting in proxy-up logic for command substitution and diagnostic output, plus configuration additions to the showcase integration test task including directory context and Rust backtrace environment variable. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing dir to test:integration:showcase task so mise --env tls runs from tests/ where mise.tls.toml exists, correctly loading TLS environment variables (CS_DATABASE__HOST and CS_DATABASE__PORT).
Fix quoting bug in proxy:up container detection where unquoted variable expansions collapsed multi-line docker ps output, causing grep and cut to select the wrong container when multiple postgres containers are running.
Summary by CodeRabbit
Tests
Bug Fixes